[WIP] Deprecate TerminalReporter.writer - #2990
Closed
nicoddemus wants to merge 4 commits into
Closed
Conversation
Improve getscopeitem assertion message
nicoddemus
force-pushed
the
deprecate-tr-writer-2984
branch
from
November 30, 2017 20:49
3b4bdc7 to
5b6b27a
Compare
nicoddemus
force-pushed
the
deprecate-tr-writer-2984
branch
2 times, most recently
from
November 30, 2017 22:03
16f943a to
7dd1c3c
Compare
nicoddemus
force-pushed
the
deprecate-tr-writer-2984
branch
from
November 30, 2017 22:59
7dd1c3c to
b2f9844
Compare
|
|
||
| @property | ||
| def writer(self): | ||
| warnings.warn(TERMINAL_REPORTER_WARNING, stacklevel=2) |
Member
There was a problem hiding this comment.
i propose to rename the internal property and trigger the deprecation also on the changing of self._tw to get bad players in line
RonnyPfannschmidt
approved these changes
Dec 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that this is meant to be merged after #2989 and into the
featuresbranch.